Skip to content

fix: check existence of backuprepo before creating a backup#337

Merged
gnolong merged 2 commits intomainfrom
support/check-existence-of-backuprepo-before-creating-a-backup
May 10, 2024
Merged

fix: check existence of backuprepo before creating a backup#337
gnolong merged 2 commits intomainfrom
support/check-existence-of-backuprepo-before-creating-a-backup

Conversation

@gnolong
Copy link
Copy Markdown
Contributor

@gnolong gnolong commented May 8, 2024

check existence of backuprepo before creating a backup

@gnolong gnolong linked an issue May 8, 2024 that may be closed by this pull request
@github-actions github-actions Bot added the size/M Denotes a PR that changes 30-99 lines. label May 8, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 42.81%. Comparing base (2c04abc) to head (c0f492c).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/cmd/cluster/dataprotection.go 56.00% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   42.80%   42.81%   +0.01%     
==========================================
  Files         213      213              
  Lines       29109    29134      +25     
==========================================
+ Hits        12459    12473      +14     
- Misses      15109    15116       +7     
- Partials     1541     1545       +4     
Flag Coverage Δ
unittests 42.81% <56.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

existDefaultBackupRepo = true
break
}
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks if existing more than one backupRepo, only need one default backupRepo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@gnolong gnolong requested a review from wangyelei May 9, 2024 05:51
@gnolong gnolong merged commit 9a0c477 into main May 10, 2024
@gnolong gnolong deleted the support/check-existence-of-backuprepo-before-creating-a-backup branch May 10, 2024 04:33
@github-actions github-actions Bot added this to the Release 0.9.0 milestone May 10, 2024
@gnolong gnolong restored the support/check-existence-of-backuprepo-before-creating-a-backup branch May 19, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Check existence of BackupRepo before creating a Backup

4 participants